Skip to content

Add better assets compression to CE - #4476

Merged
zoldar merged 5 commits into
masterfrom
better-assets-compression-in-ce
Sep 3, 2024
Merged

Add better assets compression to CE#4476
zoldar merged 5 commits into
masterfrom
better-assets-compression-in-ce

Conversation

@ruslandoga

@ruslandoga ruslandoga commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Changes

This PR enables static assets compression in CE. And additionally adds a library with better Gzip and Brotli defaults.

Relevant card: https://3.basecamp.com/5308029/buckets/29267832/card_tables/cards/7559344001

Right now CE sends static assets uncompressed (unless the reverse proxy compresses them).

https://github.com/hauleth/phoenix_bakery digests statis assets (on mix phx.digest) to (better compressed) gzip and also brotli so that Plug.Static :gzip and :brotli options could be set to true which would make it serve well compressed static assets. This would be useful once we start removing reverse-proxies from the default CE setup.

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga
ruslandoga marked this pull request as ready for review August 28, 2024 06:00
@ruslandoga
ruslandoga requested review from a team August 28, 2024 06:00
@ruslandoga ruslandoga changed the title add better assets compression to ce Add better assets compression to CE Aug 28, 2024
Comment thread Dockerfile Outdated
@ruslandoga ruslandoga added the self-hosting Anything self-hosted label Aug 28, 2024
@zoldar
zoldar force-pushed the better-assets-compression-in-ce branch from f4af922 to 51d7597 Compare September 3, 2024 11:46
@zoldar
zoldar merged commit 6c7f123 into master Sep 3, 2024
@zoldar
zoldar deleted the better-assets-compression-in-ce branch September 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

self-hosting Anything self-hosted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants