Don't require TOTP vault key in CE - #4317
Merged
Merged
Conversation
ruslandoga
force-pushed
the
fallback-to-secret-key-base-if-no-totp-secret
branch
from
July 7, 2024 09:46
ce957dd to
73a8f51
Compare
ruslandoga
marked this pull request as ready for review
July 7, 2024 09:46
ruslandoga
force-pushed
the
fallback-to-secret-key-base-if-no-totp-secret
branch
2 times, most recently
from
July 7, 2024 10:07
d8ed09f to
5d78b6e
Compare
ruslandoga
force-pushed
the
fallback-to-secret-key-base-if-no-totp-secret
branch
from
July 7, 2024 10:32
5d78b6e to
c3bc9ca
Compare
zoldar
approved these changes
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the requirement for TOTP_VAULT_KEY by generating it from SECRET_KEY_BASE if not set.
Tests
Changelog
Documentation
Dark mode