Filtering Search Console keywords - #4077
Merged
Merged
Conversation
ukutaht
force-pushed
the
search-console-filtering
branch
from
May 7, 2024 13:06
2e193c4 to
d689d60
Compare
8 tasks
ukutaht
force-pushed
the
search-console-filtering
branch
from
May 9, 2024 09:06
d689d60 to
dc1ad1e
Compare
ukutaht
marked this pull request as ready for review
May 9, 2024 09:10
aerosol
reviewed
May 9, 2024
ukutaht
force-pushed
the
search-console-filtering
branch
from
May 9, 2024 12:55
2a27c62 to
022e110
Compare
macobo
approved these changes
May 13, 2024
| with {:ok, site} <- ensure_search_console_property(site), | ||
| {:ok, access_token} <- maybe_refresh_token(site.google_auth), | ||
| {:ok, search_console_filters} <- | ||
| SearchConsole.Filters.transform(site.google_auth.property, filters), |
Contributor
There was a problem hiding this comment.
This is going to cause an annoying conflict with #4082. I propose we merge this before that PR since I have an idea on how to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes and expands the capability to filter Search Console keywords with our integration.
I saw @macobo removing some code that was not functional in #4068. However, this code is worth fixing because it's not that complicated while being a highly requested feature.
I was able to fix the feature and improve the following:
is,member,matches,matches_member)event:pageandvisit:entry_pagefilters for the purpose of keyword dataDemo (In which I find a typo that has since been fixed)
EDIT: Since recording this @aerosol and I have also added impression, CTR and position data to the keyword modal
Search.Console.Demo.mp4
Tests
Changelog
Documentation
Dark mode