Fix escaping of source filters - #3930
Merged
Merged
Conversation
macobo
reviewed
Mar 22, 2024
macobo
approved these changes
Mar 22, 2024
macobo
left a comment
Contributor
There was a problem hiding this comment.
Typo in changelog, other than that LGTM
zoldar
approved these changes
Mar 22, 2024
zoldar
force-pushed
the
escape-source-filters
branch
from
March 22, 2024 10:12
472956b to
7e3e989
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I tried making escaping more DRY in general but couldn't make it work with custom prop filters which are special.
Fixes #3893
Tests
Changelog
Documentation
Dark mode