Escape special regex characters - #3634
Merged
Merged
Conversation
aerosol
approved these changes
Dec 21, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Filters are currently broken when using special characters like
.and(in your filters. This PR fixes that.It also makes a subtle change to how wildcards are interpreted and applied.
*and**used to be interpreted differently, but now they are completely equivalent. It's a breaking change but only for people who relied on the single*behaviour. We believe it's very rare and therefore not a big problem to make the change.Tests
Changelog
Documentation
Dark mode