remove custom_dimension_filter feature and views_per_visit_metric flags - #2996
Conversation
BundleMonFiles updated (1)
Unchanged files (6)
Total files change -80B -0.01% Final result: ✅ View report in BundleMon website ➡️ |
| defp get_flags(user) do | ||
| %{ | ||
| custom_dimension_filter: FunWithFlags.enabled?(:custom_dimension_filter, for: user), | ||
| views_per_visit_metric: FunWithFlags.enabled?(:views_per_visit_metric, for: user) |
There was a problem hiding this comment.
Can views_per_visit_metric be enabled as well?
Request: #131 (comment)
There was a problem hiding this comment.
Can views_per_visit_metric be enabled as well?
@ruslandoga, the views_per_visit_metric flag is actually redundant. It's a duplicate that can be safely deleted now.
We used a visits_metric flag for both visits and views_per_visits metrics. And that flag was removed in #2898, so in the current master the views_per_visit metric is enabled for everyone.
4d5f19d to
79bcdf4
Compare
|
@RobertJoonas could you take a look? I think you're most familiar with this stuff |
| } | ||
|
|
||
| function shouldLinkToFilterModal(site, key) { | ||
| return key !== 'props' || site.flags.custom_dimension_filter |
There was a problem hiding this comment.
I lack context here but sanity check -- shouldn't we retain the key !== 'props' condition?
There was a problem hiding this comment.
I lack context here too (and I was uncertain if I should even open this PR).
My thinking was, if custom_dimension_filter is enabled for all, then it's always true, so even if key !== 'props' returns false, the end result is still true because of ||.
There was a problem hiding this comment.
The key !== 'props' check makes sure that if key is anything other than 'props' (e.g. 'page') then it should return true, no matter the flag status. We can remove that too as we don't need any special handling for props anymore, all of the options should be links.
|
@ruslandoga could you resolve the CHANGELOG conflict please? |
60801b8 to
a246875
Compare
| <span className="inline-block w-full truncate">{filterText(key, value, query)}</span> | ||
| <PencilSquareIcon className="w-4 h-4 ml-1 cursor-pointer group-hover:text-indigo-700 dark:group-hover:text-indigo-500" /> | ||
| </Link> | ||
| <div |
There was a problem hiding this comment.
Oops, this shouldn't be included, since it was using a !shouldLinkToFilterModal(site, key) check.
Changes
This PR enables custom dimension filter for self-hosters.
Relevant discussion: #2984
This PR is based on #2898
Tests
Changelog
Documentation
Dark mode