Remove the ability to collapse the main graph + transition bug fix - #2627
Merged
Conversation
vinibrsl
force-pushed
the
remove-hide-top-graph
branch
from
January 26, 2023 18:05
19a8a1d to
6fc2f2b
Compare
BundleMonFiles updated (1)
Unchanged files (6)
Total files change -93B -0.01% Final result: ✅ View report in BundleMon website ➡️ |
This commit removes the ability to collapse the top graph. The graph collapsed whenever `metric` was falsy. I removed all related code to that. Metric now defaults to visitors. We want to add new items to top stats, and this commit will make it easier to change it. Also, there's currently a bug where top stats is randomly collapsing, which should be fixed by this commit.
vinibrsl
force-pushed
the
remove-hide-top-graph
branch
from
January 26, 2023 18:20
6fc2f2b to
9280fad
Compare
The graph loading state shows and hides the graph conditionally depending on whether the data is loaded, loading or refreshing. The current code is a bit difficult to read because its big conditionals. This commit refactors the loading state making it easier to read. This commit also fixes a bug where the graph wasn't fading out when changing metrics.
aerosol
approved these changes
Jan 31, 2023
aerosol
left a comment
Member
There was a problem hiding this comment.
Very hard to track all those state containers, but I've run it locally and it looked good with no errors
vinibrsl
added a commit
that referenced
this pull request
Jan 31, 2023
…2627) * Remove the ability to collpase the top graph This commit removes the ability to collapse the top graph. The graph collapsed whenever `metric` was falsy. I removed all related code to that. Metric now defaults to visitors. We want to add new items to top stats, and this commit will make it easier to change it. Also, there's currently a bug where top stats is randomly collapsing, which should be fixed by this commit. * Refactor graph and top stats loading state The graph loading state shows and hides the graph conditionally depending on whether the data is loaded, loading or refreshing. The current code is a bit difficult to read because its big conditionals. This commit refactors the loading state making it easier to read. This commit also fixes a bug where the graph wasn't fading out when changing metrics.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the ability to collapse the main graph. The graph collapsed whenever
metricwas a falsy value (undefined,null,""). I removed all code related to that.metricshould default tovisitorsalways.We want to add new items to top stats, and this PR will make it easier to change it. Also, there's currently a bug where top stats is randomly collapsing, which should be fixed by this PR.
This pull request also fixes a bug where the graph wasn't fading out when changing metrics.
Preview
preview.webm