Reject events with long URIs and data URIs - #2536
Merged
Merged
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
ukutaht
approved these changes
Dec 21, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes a change to ingestion that rejects events with data URIs and long URIs.
We haven't seen a practical case for tracking data URIs, and those can actually cause some noise on the dashboard when triggered by a browser extension or any other external source.
Additionally, long URIs are also rejected. I set a maximum length of 2,000 characters for pathnames, which should be a reasonable size. I've searched for an official specification for pathnames, but RFC 2616 says there is no limit, so each browser implements it differently. Modern browsers accept gigantic URIs due data URIs I mentioned before.
Tests
Changelog
Documentation
Dark mode