Return empty list when breaking down by event:page without events - #2530
Merged
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
I think a changelog entry under the |
ukutaht
approved these changes
Dec 19, 2022
This commit fixes a bug with pagination where breaking down by event:page would always return results despite pagination. Closes #2255
vinibrsl
force-pushed
the
fix-breakdown-event-page-pagination
branch
from
December 19, 2022 12:42
24301cb to
3dd73ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This commit fixes a bug with pagination where breaking down by event:page would always return results despite pagination.
Closes #2255
Tests
Changelog
Documentation
Dark mode