Adds list-based country report option - #1381
Merged
Merged
Conversation
Contributor
|
looking great! thanks @Vigasaurus! |
ukutaht
requested changes
Oct 13, 2021
ukutaht
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #1376 as discussed, and sets up for future additional reports in a similar manner for regions/cities
I do think some of the UI strings could be improved/changed, but these are what I came up with
I apologize in advance for all the PR reviews I put on your plate in the past few days Uku 👀Tests
Changelog
Documentation
Screenshots