fix: stop replaying empty assistant messages to the provider - #29169
Open
Classic298 wants to merge 1 commit into
Open
fix: stop replaying empty assistant messages to the provider#29169Classic298 wants to merge 1 commit into
Classic298 wants to merge 1 commit into
Conversation
A generation that fails or is aborted before its first token is stored as an assistant message with no content. Every later message in that chat replays it to the provider, and providers that reject empty assistant content refuse the whole request, so the chat stays broken until the row is removed from the database by hand. Empty assistant turns are now dropped when the history is rebuilt for the provider. Messages carrying tool calls or output items are untouched, and empty user, system and tool messages are left alone so nothing else about the payload changes. The filter sits at the point the normal completion path and the tool-approval resume path share, so it also covers payloads posted straight to the API rather than loaded from a saved chat. Chats already broken on disk recover on their next message, no migration needed. Fixes open-webui#25083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generation that fails or is aborted before its first token is stored as an assistant message with no content. Every later message in that chat replays it to the provider, and providers that reject empty assistant content refuse the whole request, so the chat stays broken until the row is removed from the database by hand.
Empty assistant turns are now dropped when the history is rebuilt for the provider. Messages carrying tool calls or output items are untouched, and empty user, system and tool messages are left alone so nothing else about the payload changes.
The filter sits at the point the normal completion path and the tool-approval resume path share, so it also covers payloads posted straight to the API rather than loaded from a saved chat. Chats already broken on disk recover on their next message, no migration needed.
Fixes #25083
Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.