fix: refresh selected folder on folder route changes - #29116
Open
LambIessz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for helping improve Open WebUI. Please make sure the linked Issue or Discussion explains the user-facing problem, the expected outcome, and any relevant examples or constraints.
Code contributions are not the default path. Open a code pull request only when a maintainer asks for one, or for narrow i18n/localization updates. For real, reproducible bugs, start with a well-described Issue. For feature requests, UI/UX changes, behavior changes, architecture changes, suspected fixes, or unconfirmed approaches, start with an active Discussion.
If you have implementation notes, include them as reference in the Issue or Discussion. A local diff, patch, or branch can be useful context, but it does not mean a pull request is expected or will be reviewed.
Unsolicited PRs may be closed without review, especially when they introduce product, architecture, compatibility, dependency, or maintenance decisions that have not been discussed.
Checklist
devbranch.Closes #29022.Title Prefix
Use one of the following prefixes:
Summary
Closes #29022.
Folder routes now reload the selected folder when the dynamic
folderIdroute parameter changes. This keepsselectedFolderaligned with the current/folders/:folderIdURL, including when navigating through nested folders or after moving a folder in or out of a parent folder.The backend already applies folder project settings, including
data.system_prompt, when the completion request contains the correctfolder_id. Keeping the route store in sync prevents new chats opened from a nested folder from using stale folder context.Testing
npx prettier --check 'src/routes/(app)/folders/[folderId]/+page.svelte'npx eslint 'src/routes/(app)/folders/[folderId]/+page.svelte'git diff --checknpx svelte-check --tsconfig ./tsconfig.json 2>&1 | Select-String -Pattern 'src\\routes\\\(app\)\\folders\\\[folderId\]\\\+page\.svelte' -Context 0,5The filtered
svelte-checkcommand reported no diagnostics for the changed file. A fullnpm run checkstill reports existing repository-wide diagnostics unrelated to this change.Changelog Entry
Added
Changed
Fixed
/folders/:folderIdroutes so nested folder chats use the current folder context.Removed
Security
Breaking Changes
Additional Context
This change is intentionally scoped to the folder route state sync. It does not change backend folder permissions or folder project setting application.
Contributor License Agreement