Skip to content

pulse: chart dbengine extent decompression throughput - #23671

Draft
stelfrag wants to merge 1 commit into
netdata:masterfrom
stelfrag:dbengine-decompression-throughput
Draft

pulse: chart dbengine extent decompression throughput#23671
stelfrag wants to merge 1 commit into
netdata:masterfrom
stelfrag:dbengine-decompression-throughput

Conversation

@stelfrag

@stelfrag stelfrag commented Aug 28, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator
Summary
  • Add a dbengine_decompression_throughput chart exposing compressed and uncompressed extent data in MiB/s.
  • Surface decompression volume and expansion ratio, including decompression on extent-cache hits.

Summary by CodeRabbit

  • New Features
    • Added a database engine chart showing compressed and uncompressed extent decompression throughput in MiB/s.
    • Throughput metrics are updated incrementally for clearer performance monitoring.

@stelfrag
pulse: chart dbengine extent decompression throughput
ad691c3 
before/after_decompress_bytes were collected but never exposed. Extents are
decompressed whole on every access, including extent cache hits, so this shows
read-side decompression volume and the expansion ratio.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ccacfeec-20a9-40ab-8a01-4a26f6b79e66

📥 Commits

Reviewing files that changed from the base of the PR and between 7953b76 and ad691c3.

📒 Files selected for processing (1)
  • src/daemon/pulse/pulse-db-dbengine.c

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Changes

DB engine throughput

Layer / File(s) Summary
Decompression throughput chart
src/daemon/pulse/pulse-db-dbengine.c		 Adds the dbengine_decompression_throughput chart with compressed and uncompressed extent throughput dimensions. Values use incremental statistics from stats_array[13] and stats_array[14] and report MiB/s.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ad691

This PR adds decompression throughput and expansion metrics to the database engine chart without any identified merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: thiagoftsm, vkalintiris

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a pulse chart for DB engine extent decompression throughput.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 28, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm will be requested when the pull request is marked ready for review thiagoftsm is a code owner
@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris will be requested when the pull request is marked ready for review vkalintiris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/daemon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stelfrag