Adjust eBPF in static buidling - #23612
Draft
thiagoftsm wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #23604
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Make bundled libraries always build as static and use
STATIC_BUILDto control whether Netdata links statically, fixing static eBPF/protobuf selection. PreviouslyBUILD_SHARED_LIBSmirroredSTATIC_BUILD; nowBUILD_SHARED_LIBSis forced OFF and only bundled deps are affected, whileSTATIC_BUILDgoverns final linking.CMakeLists.txt: unconditionally setsBUILD_SHARED_LIBS=OFF; intent remains inSTATIC_BUILD.NetdataEBPFLegacy.cmakeandNetdataProtobuf.cmake: switch checks fromBUILD_SHARED_LIBStoSTATIC_BUILDto choose static artifacts, resolving incorrect behavior in static builds (issue ebpf-code-legacy packages fetch the kernel-collector flavor selected by an inverted condition #23604).netdata-installer.sh: removes-DBUILD_SHARED_LIBS=Offsince CMake enforces it.-DSTATIC_BUILD=Onto request fully static binaries; stop setting-DBUILD_SHARED_LIBS. Dynamic builds continue to link against system libs; bundled deps are static-only.Written for commit 823e819. Summary will update on new commits.