Skip to content

chore: introduce _TestInfoEx interface for builtin fixtures - #42352

Open
Dmitry Gozman (dgozman) wants to merge 2 commits into
microsoft:mainfrom
dgozman:test-info-ex
Open

chore: introduce _TestInfoEx interface for builtin fixtures#42352
Dmitry Gozman (dgozman) wants to merge 2 commits into
microsoft:mainfrom
dgozman:test-info-ex

Conversation

@dgozman

@dgozman Dmitry Gozman (dgozman) commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Builtin fixtures in index.ts now depend on the new _TestInfoEx interface instead of TestInfoImpl.
  • Trace-related methods are exposed directly on the interface; per-test callbacks are grouped under _callbacks.
  • Trace recording names/paths and page screenshot dedupe moved into ArtifactsRecorder; SnapshotRecorder is inlined into it.

@dgozman
chore: introduce _TestInfoEx interface for builtin fixtures
b96e2b8 
Builtin fixtures in index.ts now depend on the _TestInfoEx interface
instead of TestInfoImpl:
- trace-related methods are exposed directly on the interface;
- per-test callbacks are grouped under _callbacks;
- trace recording names/paths and page snapshot dedupe moved into
  ArtifactsRecorder.
@dgozman
chore: inline SnapshotRecorder into ArtifactsRecorder
79dabac
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

4 failed
❌ [chrome] › mcp/annotate.spec.ts:269 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:291 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-chrome
❌ [msedge] › mcp/annotate.spec.ts:57 › should capture multiple screenshots in one annotation @mcp-windows-latest-msedge
❌ [msedge] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-windows-latest-msedge

8138 passed, 1361 skipped

Merge workflow run.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`

51283 passed, 1238 skipped

Merge workflow run.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the failing CI.

🟢 All four failures are pre-existing flakes — the PR is clear

Every failure is in mcp/annotate.spec.ts on Windows Chrome/Edge, and each one flips verdict across the run history on SHAs this PR can't be responsible for. This diff only touches test-runner internals (_TestInfoEx, testInfo, tracing, ArtifactsRecorder), none of which the MCP annotate/dashboard flow exercises.

Details

Overall: No failure reaches the changed code. The PR reworks builtin fixtures and artifact/trace recording in packages/playwright/src/; the failing tests exercise the MCP dashboard annotate flow, an unrelated path.

Pre-existing flake / infra

All four are the same annotate story, flaky across the aggregated test-results DB (final verdict flips between runs, and retries rescue them within a run), failing on SHAs unrelated to this PR:

  • [msedge] › mcp/annotate.spec.ts:57 › should capture multiple screenshots in one annotation — failed 15 of 3559 runs, passed the other 3544 (15 within-run rescues), on other SHAs.
  • [msedge] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed — failed 15 of 3559 runs, passed 3544 (24 rescues), on other SHAs.
  • [chrome] › mcp/annotate.spec.ts:269 › should start dashboard and annotate when no dashboard is running — failed 7 of 3559 runs, passed 3552, on another SHA.
  • [chrome] › mcp/annotate.spec.ts:291 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate — failed 6 of 3559 runs, passed 3553, on another SHA.

Triaged by the Playwright bot - agent run

pavelfeldman
Pavel Feldman (pavelfeldman) reviewed Aug 21, 2026
View reviewed changes

@pavelfeldman Pavel Feldman (pavelfeldman) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, need context!

@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman Pavel Feldman (pavelfeldman) pavelfeldman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @pavelfeldman