Fix order-dependent transform permissions in tests - #81404
Open
bgrabow wants to merge 3 commits into
Open
Conversation
A handful of independent, low-risk fixes bundled together — each too small to ship on its own, each a behavior improvement that also closes a minor hardening gap. Reduce DB load / avoid unconditional work: - Settings cache: a settings-last-updated cookie now triggers a cheap single-row staleness check and reloads only if the cache is genuinely behind, instead of unconditionally reloading the whole settings table. Exposes restore-cache-if-needed! with a :force-check? option as the shared "reload if actually stale" primitive the cookie path now uses. Reduce log noise: - CORS origin validation runs on every request's raw Origin header, so it now parses that client-supplied value with the silent try-parse-url rather than the variant that logs "Invalid URL" at ERROR — a malformed Origin no longer fills the operator's error log. Parsing behavior is otherwise identical, so no CORS allow/deny decision changes. Correctness (case-insensitivity): - forgot_password throttles on the lower-cased email, matching the case-insensitive account lookup, so User@x and user@x share one bucket rather than each getting a fresh allowance. Add a missing throttle: - PUT /api/user/:id/password throttles the old_password re-auth check, which previously had none, bringing it in line with the other credential endpoints.
bgrabow
marked this pull request as ready for review
August 28, 2026 20:18
bgrabow
enabled auto-merge (squash)
August 28, 2026 20:58
bgrabow
disabled auto-merge
August 28, 2026 20:58
bgrabow
enabled auto-merge (squash)
August 28, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default permissions granted for a new DWH are dependent on the minimum permissions granted for other DWHs in the same instance. Therefore, when creating a new DWH the permission you get are dependent on the order of other DWHs created.
Some of our tests create DWHs and depend on the permissions granted for those DWHs, but don't explicitly set the permissions. This PR adds explicit specification of permissions to those tests so they're no longer order-dependent.