Skip to content

Fix order-dependent transform permissions in tests - #81404

Open
bgrabow wants to merge 3 commits into
masterfrom
worktree-redshift-transform-403
Open

Fix order-dependent transform permissions in tests#81404
bgrabow wants to merge 3 commits into
masterfrom
worktree-redshift-transform-403

Conversation

@bgrabow

@bgrabow bgrabow commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

The default permissions granted for a new DWH are dependent on the minimum permissions granted for other DWHs in the same instance. Therefore, when creating a new DWH the permission you get are dependent on the order of other DWHs created.

Some of our tests create DWHs and depend on the permissions granted for those DWHs, but don't explicitly set the permissions. This PR adds explicit specification of permissions to those tests so they're no longer order-dependent.

dpsutton and others added 2 commits August 28, 2026 11:47
A handful of independent, low-risk fixes bundled together — each too small to
ship on its own, each a behavior improvement that also closes a minor
hardening gap.

Reduce DB load / avoid unconditional work:
- Settings cache: a settings-last-updated cookie now triggers a cheap
  single-row staleness check and reloads only if the cache is genuinely
  behind, instead of unconditionally reloading the whole settings table.
  Exposes restore-cache-if-needed! with a :force-check? option as the shared
  "reload if actually stale" primitive the cookie path now uses.

Reduce log noise:
- CORS origin validation runs on every request's raw Origin header, so it now
  parses that client-supplied value with the silent try-parse-url rather than
  the variant that logs "Invalid URL" at ERROR — a malformed Origin no longer
  fills the operator's error log. Parsing behavior is otherwise identical, so
  no CORS allow/deny decision changes.

Correctness (case-insensitivity):
- forgot_password throttles on the lower-cased email, matching the
  case-insensitive account lookup, so User@x and user@x share one bucket
  rather than each getting a fresh allowance.

Add a missing throttle:
- PUT /api/user/:id/password throttles the old_password re-auth check, which
  previously had none, bringing it in line with the other credential
  endpoints.
@ci-conductor

ci-conductor Bot commented Aug 28, 2026

Copy link
Copy Markdown

View on CI Conductor

@bgrabow
bgrabow marked this pull request as ready for review August 28, 2026 20:18
@bgrabow bgrabow added the backport Automatically create PR on supported major release branches on merge label Aug 28, 2026
@bgrabow
bgrabow enabled auto-merge (squash) August 28, 2026 20:58
@bgrabow
bgrabow disabled auto-merge August 28, 2026 20:58
@bgrabow
bgrabow enabled auto-merge (squash) August 28, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Automatically create PR on supported major release branches on merge .Team/Graphy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants