fix(ui): sync quick insert highlight with input method - #5176
Open
KDOJP wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent highlighting in the Quick Insert menu when switching between mouse and keyboard navigation.
Previously, hovering one item while navigating with the arrow keys could make the hovered item appear selected even though Enter executed a different internally active item.
Closes #5175
Changes
Expected behavior
Testing
pnpm --filter @muyajs/core lint(passes with existing warnings)pnpm --filter @muyajs/core lint:typespnpm exec stylelint packages/muya/src/ui/paragraphQuickInsertMenu/index.csspnpm --filter @muyajs/core test(1,438 tests passed)pnpm --filter @muyajs/core check-circularpnpm --filter muya-e2e exec playwright test tests/ui/slash-menu.spec.ts --project=chromium --workers=1(8 tests passed)The full CSS lint command still reports an unrelated, pre-existing
no-descending-specificityerror insrc/assets/styles/blockSyntax.css:945; the changed stylesheet passes targeted Stylelint.