Skip to content

Fix compiler warnings on Windows 64-bit - #58

Merged
hartwork merged 1 commit into
libexpat:masterfrom
vstinner:win64_warn
Jun 23, 2017
Merged

Fix compiler warnings on Windows 64-bit#58
hartwork merged 1 commit into
libexpat:masterfrom
vstinner:win64_warn

Conversation

@vstinner

Copy link
Copy Markdown
Contributor

Explicitly cast on integer downcasting to fix compiler warnings.

Explicitly cast on integer downcasting to fix compiler warnings.
@vstinner

Copy link
Copy Markdown
Contributor Author

Compiling libexpat on Windows 64-bit emits two warnings in siphash.h, example:

siphash.h(201): warning C4244: 'initializing': conversion from '__int64' to 'char', possible loss of data

The warnings were reported in CPython which embeds a copy of libexpat: http://bugs.python.org/issue30726#msg296590

@vstinner

Copy link
Copy Markdown
Contributor Author

The two warnings:

Warning	C4267	'=': conversion from 'size_t' to 'unsigned char', possible loss of data	_elementtree	siphash.h	316	
siphash.h(201): warning C4244: 'initializing': conversion from '__int64' to 'char', possible loss of data

@hartwork
hartwork merged commit 788bff7 into libexpat:master Jun 23, 2017
@hartwork

Copy link
Copy Markdown
Member

All in unmodified, thanks for your contribution!

@hartwork hartwork added this to the 2.2.2 milestone Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants