Fix UNC path handling during install root path validation - #8258
Open
jeremy99981 wants to merge 3 commits into
Open
Fix UNC path handling during install root path validation#8258jeremy99981 wants to merge 3 commits into
jeremy99981 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This fixes installer path normalization for repository/log root paths on Windows UNC shares.
Today
InstallPostreplaces all\\with/before callingos.MkdirAll. For UNC paths (e.g.\\imb-nas\\repositories) this rewrite can turn a valid Windows network path into an invalid path and trigger:Repository root path is invalid: mkdir //...: The specified path is invalid.This PR keeps native Windows paths unchanged while preserving existing normalization behavior on non-Windows platforms.
Link to the issue: #2550
Checklist
Test plan
TestNormalizeInstallRootPathByOSininternal/route/install_test.goto cover:git diff --check.go testin this environment because the Go toolchain is unavailable in the current runner (go: command not found). CI should execute the full test suite.