fix: data field tab (backport #2288) - #2712
Open
mergify[bot] wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
When a user edits and saves a field under a non-default Data Fields tab, the form layout is re-
rendered and the selected tab is reset to the first tab, such as Deal Details. This makes the
user lose their current context after saving.
Root cause
FieldLayoutkept the selected tab in local component state initialized to0. When the DataFields layout was remounted or reloaded after save, that local state was recreated and the first
tab became selected again.
Changes
Activities.vueso it survivesDataFieldsremounts.v-model:tabIndexandv-model:tabNamesupport toFieldLayout.name, which also works when tab labels areduplicated.
sessionStorageperdoctypeanddocname, so thetab can be restored after page remounts.
and session storage restore.
Expected behaviour after fix
After editing and saving a field under another Data Fields tab, the user stays on the same tab
instead of being redirected back to the first tab.
Test plan
frontend/tests/unit/fieldLayoutTabState.test.js.cd frontend yarn test:runcloses #2270
This is an automatic backport of pull request #2288 done by Mergify.