test(portal): stop the X.509 rate limit test crossing seconds - #14884
Open
thomaseizinger wants to merge 1 commit into
Open
test(portal): stop the X.509 rate limit test crossing seconds#14884thomaseizinger wants to merge 1 commit into
thomaseizinger wants to merge 1 commit into
Conversation
The bucket holds one token and refills one per second, so two attempts 18ms apart still straddle a second boundary and the second is admitted.
|
coverage: 81.624%. first build — fix-flaky-x509-rate-limit-test into main |
thomaseizinger
enabled auto-merge
August 28, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortalAPI.Client.SocketTest"rate limits failed X.509 authentication before repeating validation" fails intermittently, for example here: https://github.com/firezone/firezone/actions/runs/33148396459/job/98774513409?pr=14883Other tests in this file already work around this by using
Enum.anyinstead:firezone/elixir/test/portal_api/client/socket_test.exs
Lines 333 to 340 in 9c86ea6
This PR applies the same pattern to the x509 rate limiter test.