fix(gui-client): don't block shutdown on notification - #13835
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux GUI client’s notification handling to avoid a shutdown deadlock caused by notify-rust’s on_close using Tokio’s blocking thread-pool. Instead, it keeps the D-Bus connection alive by awaiting the async action-wait API inside a spawned async task.
Changes:
- Replace
notification.on_close(|| {})withnotification.wait_for_action_async(|_| {}).awaiton Linux. - Ensure notification action handling stays on the async scheduler rather than Tokio’s blocking pool during runtime shutdown.
jamilbk
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to display notifications reliably on Linux, we need to attach a handler to it, otherwise the D-bus connection gets dropped immediately. Using
on_closeuses the blocking thread-pool internally however which can cause a dead-lock during runtime shutdown because tasks on the blocking thread-pool cannot be preempted, preventing the GUI process from exiting if there is still a not-dismissed notification.To fix this, we use the
asyncvariant to wait for the notification action.