Skip to content
This repository was archived by the owner on Dec 14, 2021. It is now read-only.

fix document - #22

Open
dcb9 wants to merge 1 commit into
ethjs:masterfrom
dcb9:patch-1
Open

fix document#22
dcb9 wants to merge 1 commit into
ethjs:masterfrom
dcb9:patch-1

Conversation

@dcb9

@dcb9 dcb9 commented Mar 1, 2018

Copy link
Copy Markdown

there is no filters property on ETH object

self.filter = new EthFilter(query, self.options.query);

ethjs

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • [ x ] You have followed our contributing guidelines
  • [ x ] Pull request has tests (we are going for 100% coverage!)
  • [ x ] Code is well-commented, linted and follows project conventions
  • [ x ] Documentation is updated (if necessary)
  • [ x ] Internal code generators and templates are updated (if necessary)
  • [ x ] Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling c3cacb3 on dcb9:patch-1 into 356ed3c on ethjs:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants