Skip to content

Replace IPs in pipeline tests with the allowed ones - #2327

Merged
marc-gr merged 4 commits into
elastic:masterfrom
marc-gr:change-test-ips
Dec 13, 2021
Merged

Replace IPs in pipeline tests with the allowed ones#2327
marc-gr merged 4 commits into
elastic:masterfrom
marc-gr:change-test-ips

Conversation

@marc-gr

@marc-gr marc-gr commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Replace IPs in pipeline tests with ones in the allowed list. This way we ensure GeiIP is supported for all of them when testing against 8.0.0 stack.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Relates to elastic/elastic-package#605

@marc-gr marc-gr added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Dec 9, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Dec 10, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-13T08:42:27.672+0000

  • Duration: 69 min 45 sec

  • Commit: e1a8168

Test stats 🧪

Test Results
Failed 0
Passed 2203
Skipped 2
Total 2205

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to release the new elastic-package to check if all addresses are up-to-date.

@marc-gr
marc-gr merged commit 5429e34 into elastic:master Dec 13, 2021
@marc-gr
marc-gr deleted the change-test-ips branch December 13, 2021 09:52
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Replace IPs in pipeline tests with the allowed ones

* Generate test files

* Add PR number to changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants