Remove event.original processors from several remaining integrations part 1 - #13521
Conversation
|
/test |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
expvar |
4291.85 | 2570.69 | -1721.16 (-40.1%) | 💔 |
heap |
3802.28 | 3174.6 | -627.68 (-16.51%) | 💔 |
Package hadoop 👍(2) 💚(1) 💔(2)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
cluster |
5882.35 | 4784.69 | -1097.66 (-18.66%) | 💔 |
datanode |
12987.01 | 10101.01 | -2886 (-22.22%) | 💔 |
Package hashicorp_vault 👍(1) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
10000 | 7751.94 | -2248.06 (-22.48%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
/test |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
| conditions: | ||
| kibana: | ||
| version: ^8.7.1 || ^9.0.0 | ||
| version: ^8.11.0 || ^9.0.0 |
There was a problem hiding this comment.
Why are we changing the version here ?
There was a problem hiding this comment.
@ishleenk17 Same reason as pointed out in the next review. Please refer to that
| conditions: | ||
| kibana: | ||
| version: "^8.10.1 || ^9.0.0" | ||
| version: "^8.11.0 || ^9.0.0" |
There was a problem hiding this comment.
Why are we updating the kibana version ?
There was a problem hiding this comment.
If it is beacuse the fleet addition of processor got added in this. I am not sure if its a good idea to upgrade the kibana version just to support that.
There was a problem hiding this comment.
See #10072 (comment), this PR relies on the fleet final pipeline changes introduced in 8.11.0
There was a problem hiding this comment.
@ishleenk17 The reason is the point mentioned by @taylor-swanson
|
@efd6 @ishleenk17 @taylor-swanson @nfritts @andrewkroh Can please anyone run CI tests again and merge if applicable. Thank you |
|
/test |
|
@Alphayeeeet It looks like you will need to regenerate the test expectations for hid_bravura_monitor. |
|
@efd6 Done. Please run CI tests again |
|
/test |
|
💚 Build Succeeded
History
|
| # newer versions go on top | ||
| - version: "2.42.0" | ||
| changes: | ||
| - description: Allow @custom pipeline access to event.original without setting preserve_original_event. |
There was a problem hiding this comment.
| - description: Allow @custom pipeline access to event.original without setting preserve_original_event. | |
| - description: Allow `@custom` pipeline access to `event.original` without setting preserve_original_event. |
There was a problem hiding this comment.
Maybe change to preserve_original_event too
|
Package gcp - 2.42.0 containing this change is available at https://epr.elastic.co/package/gcp/2.42.0/ |
|
Package goflow2 - 0.5.0 containing this change is available at https://epr.elastic.co/package/goflow2/0.5.0/ |
|
Package golang - 1.8.0 containing this change is available at https://epr.elastic.co/package/golang/1.8.0/ |
|
Package hadoop - 1.9.0 containing this change is available at https://epr.elastic.co/package/hadoop/1.9.0/ |
|
Package hashicorp_vault - 1.28.0 containing this change is available at https://epr.elastic.co/package/hashicorp_vault/1.28.0/ |
|
Package hid_bravura_monitor - 1.21.0 containing this change is available at https://epr.elastic.co/package/hid_bravura_monitor/1.21.0/ |
|
Package imperva - 1.6.0 containing this change is available at https://epr.elastic.co/package/imperva/1.6.0/ |
|
Package microsoft_exchange_server - 1.4.0 containing this change is available at https://epr.elastic.co/package/microsoft_exchange_server/1.4.0/ |
Label as enhancement
Proposed commit message
Remove event.original removal processors
Related issues
Review #10072 for additional info