Skip to content

Missing vulnerability management category - #12438

Merged
kcreddy merged 0 commit into
elastic:mainfrom
craiglawson:main
Jan 28, 2025
Merged

Missing vulnerability management category#12438
kcreddy merged 0 commit into
elastic:mainfrom
craiglawson:main

Conversation

@craiglawson

@craiglawson craiglawson commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

The Tenable Vulnerability Management and Security Center integrations are not being presented when a user selects the Vulnerability Management category within the Security section of integrations, it is a very simple fix adding the below to the categories section:

- vulnerability_management

This would help new users find this integration easier when browsing via categories

@craiglawson
craiglawson requested a review from a team as a code owner January 23, 2025 14:08
@cla-checker-service

cla-checker-service Bot commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown

💚 CLA has been signed

@andrewkroh andrewkroh added Integration:tenable_sc Tenable Security Center Integration:tenable_io Tenable Vulnerability Management needs CLA User must sign the Elastic Contributor License before review. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 23, 2025
@elasticmachine

elasticmachine commented Jan 23, 2025

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@craiglawson

craiglawson commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

❌ Author of the following commits did not sign a Contributor Agreement: 244cdb7

Please, read and sign the above mentioned agreement if you want to contribute to this project

I have now signed the CLA

@craiglawson craiglawson changed the title added vuln management category Missing vulnerability management category Jan 23, 2025
@andrewkroh andrewkroh removed the needs CLA User must sign the Elastic Contributor License before review. label Jan 23, 2025
@andrewkroh

andrewkroh commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

kcreddy
kcreddy reviewed Jan 24, 2025
View reviewed changes

@kcreddy kcreddy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craiglawson,

Could you also increment the integration version in respective manifest.yml and also add changelog.yml entries?

Update Manifest: here for tenable_sc and here for tenable_io

Add changelog entry (at the top): here for tenable_sc and here for tenable_io

Example PR: #12453

@kcreddy kcreddy added the enhancement New feature or request label Jan 24, 2025
@craiglawson

craiglawson commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

I have updated the version and added a changelog entry

@kcreddy

kcreddy commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

/test

@kcreddy

kcreddy commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

Thanks @craiglawson.
Could you please fix the merge conflicts? We can move ahead with merging the PR.

@craiglawson

craiglawson commented Jan 27, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for your patience, hopefully I have resolved this now (first time PR)

@craiglawson craiglawson reopened this Jan 27, 2025
@kcreddy

kcreddy commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Jan 28, 2025

Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💔 Build #20959 failed 755c4a5e2c6fe94b9c4b004e12ba48aa60696115
  • 💚 Build #20876 succeeded 244cdb729905fa6a6509623ad2394dfb34f58441

@elastic-sonarqube

elastic-sonarqube Bot commented Jan 28, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

kcreddy
kcreddy approved these changes Jan 28, 2025
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy
kcreddy merged this pull request into elastic:main Jan 28, 2025
@kcreddy

kcreddy commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

@craiglawson, thanks for the contribution.

I just merged the PR, the new version should be released in an hour.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Package tenable_io - 3.6.1 containing this change is available at https://epr.elastic.co/package/tenable_io/3.6.1/

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Package tenable_sc - 1.28.1 containing this change is available at https://epr.elastic.co/package/tenable_sc/1.28.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@craiglawson
Missing vulnerability management category (elastic#12438)
23b7e7e 
The Tenable Vulnerability Management and Security Center integrations are not being presented when a user selects the Vulnerability Management category within the Security section of integrations, it is a very simple fix adding the below to the categories section:

  - vulnerability_management

This would help new users find this integration easier when browsing via categories.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@craiglawson
Missing vulnerability management category (elastic#12438)
b6314b1 
The Tenable Vulnerability Management and Security Center integrations are not being presented when a user selects the Vulnerability Management category within the Security section of integrations, it is a very simple fix adding the below to the categories section:

  - vulnerability_management

This would help new users find this integration easier when browsing via categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:tenable_io Tenable Vulnerability Management Integration:tenable_sc Tenable Security Center Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@craiglawson @elasticmachine @andrewkroh @kcreddy