Feature/partner-search: stop pagination at the candidate ceiling - #4399
Feature/partner-search: stop pagination at the candidate ceiling#4399Joker666 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
94015fa to
9803f91
Compare
Search reports its exact total while the list serves only the top 999 candidates, so Next could page into guaranteed-empty pages. Adds an opt-in maxBrowsableRows to the table: navigation stops at the last servable page, the footer keeps the exact total, and out-of-range deep links snap back. Wired into the three partner tables that search through the provider.
9803f91 to
3766e5a
Compare
…t/partner-search-pagination-cap
…t/partner-search-pagination-cap
Partner search: stop pagination at the candidate ceiling
Stacked on
fix/search-box-debounce-and-precedence. Addresses a limitation of #4333: a search reports its exact total (say "12,000 partners") while the list can only serve the top 999 ranked candidates, so Next kept walking into guaranteed-empty pages ("No partners found" from page 41 onward at 25 rows per page).What changed
maxBrowsableRowsonuseTable/Table(opt-in). The page count TanStack sees is clamped tomin(rowCount, maxBrowsableRows), so Next stops on the last servable page, while the footer keeps reporting the exact total fromrowCount.rowCountis 0 while a count is still loading, and clamping on that would reset a deep-linked page on every paginated table before the real count arrives.The ceiling stays a deliberate trade (see #4333); this only makes the UI honest about it.