Feature/partner-search: fix search box debounce and guard precedence - #4346
Open
Joker666 wants to merge 16 commits into
Open
Feature/partner-search: fix search box debounce and guard precedence#4346Joker666 wants to merge 16 commits into
Joker666 wants to merge 16 commits into
Conversation
Three defects in SearchBoxPersisted, all pre-existing.
`!==` binds tighter than `??`, so both guards read `x ?? ("" !== y)` rather
than `(x ?? "") !== y`. That evaluates to the param itself whenever one is
present, which is always truthy, so neither guard ever skipped.
The visible consequence is on mount. Any URL carrying the search param fired
the effect immediately and called queryParams with `del: ["page",
...resetParamsOnChange]`, so opening a shared partner search link with
sortBy=relevance stripped the sort before the user touched anything.
The clear button also never cancelled the pending debounce. It notifies
immediately, so a keystroke still waiting out the 500ms landed afterwards and
restored the term that was just cleared.
No tests: this repo has no DOM environment and no component tests, and adding
that setup is a larger change than the fix.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…box-debounce-and-precedence
Joker666
force-pushed
the
feature/partner-full-text-search-sync
branch
from
August 17, 2026 22:03
014fafc to
90b7036
Compare
Joker666
force-pushed
the
fix/search-box-debounce-and-precedence
branch
from
August 17, 2026 22:03
7efc41e to
61ee234
Compare
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
Joker666
force-pushed
the
feature/partner-full-text-search-sync
branch
from
August 17, 2026 23:09
817d7e5 to
cb8fa4a
Compare
Joker666
force-pushed
the
fix/search-box-debounce-and-precedence
branch
from
August 17, 2026 23:10
d06d7f8 to
8815bbb
Compare
…box-debounce-and-precedence
Joker666
force-pushed
the
feature/partner-full-text-search-sync
branch
from
August 18, 2026 01:55
4c19691 to
7605a40
Compare
Joker666
force-pushed
the
fix/search-box-debounce-and-precedence
branch
from
August 18, 2026 01:55
d1687c8 to
bd5e962
Compare
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
…box-debounce-and-precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the search box debounce and guard precedence
Stacked on #4343. Three pre-existing defects in
SearchBoxPersisted, called out but deliberately left alone in #4316 because they change behaviour for all 20 consumers.Guard precedence, in two places
!==binds tighter than??, so both guards readx ?? ("" !== y)rather than(x ?? "") !== y. That evaluates to the param itself whenever one is present, which is always truthy, so neither guard ever skipped.The visible consequence is on mount:
Firing calls
queryParamswithdel: ["page", ...resetParamsOnChange]. On the partners table that list is["sortBy", "sortOrder"], so opening a shared relevance-sorted search link stripped the sort before the user touched anything and the results quietly fell back tototalSaleAmountorder.Clear button never cancelled the debounce
Clearing notifies immediately, but a keystroke still waiting out the 500ms landed afterwards and restored the term that was just cleared. Now cancelled first.
Notes
#4316described this as two bugs. The precedence one is in two places, and the consumer count there is 20 files rather than 63.No tests. This repo has no DOM environment and no component tests, so adding that setup would be a larger and more debatable change than the fix. Happy to do it separately if wanted.