Guard local-driver extensions location in storage path validation - #28077
Open
br41nslug wants to merge 2 commits into
Open
Guard local-driver extensions location in storage path validation#28077br41nslug wants to merge 2 commits into
br41nslug wants to merge 2 commits into
Conversation
ComfortablyCoding
requested changes
Aug 12, 2026
Member
There was a problem hiding this comment.
As discussed, see points below.
Additional bypasses to what is listed:
- Still possible bypass via PATCH as it may check against one storage due to fallback but store in db based storage
directus/api/src/services/files.ts
Line 338 in 8bdd6e5
| // Block setting path to the extension path on the extensions storage location. | ||
| if (env['EXTENSIONS_LOCATION'] && env['EXTENSIONS_LOCATION'] === location) { | ||
| if (extensionPath && filePath.startsWith(extensionPath + '/')) { | ||
| if (extensionPath && normalizedFilePath.startsWith(extensionPath + '/')) { |
Member
There was a problem hiding this comment.
EXTENSIONS_PATH='.' will result in extensionPath being '' due to sanitize which bypasses this guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Tested Scenarios
Review Notes / Questions / Concerns
Checklist
@directus/specs)@directus/sdk) updated to reflect the changes@directus/types) updated to reflect the changes@directus/system-data) updated for changes to system collections/fields/relationsFixes CMS-2391