fix(googlecalendar): suppress notifications on hangout-link follow-up patch - #30049
Draft
AlgoArtist06 wants to merge 1 commit into
Draft
fix(googlecalendar): suppress notifications on hangout-link follow-up patch#30049AlgoArtist06 wants to merge 1 commit into
AlgoArtist06 wants to merge 1 commit into
Conversation
Contributor
|
Welcome to Cal.diy, @AlgoArtist06! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #30044
Part of the bug report in #30044: when a booking is created with Google
Calendar + Google Meet,
events.insertis called withsendUpdates: "none"so that Cal.diy manages its own confirmation emails and Google does not send a
notification. A follow-up
events.patchthen writes the Meet/hangout link intothe event description, but it omits
sendUpdatesentirely. Google thereforenotifies the attendee about the change with an "Updated invitation" email even
though no original invitation was ever sent to them - the attendee's only
interaction with the event is a phantom update email.
This change makes the follow-up patch consistent with the insert by passing
sendUpdates: "none", so Google stops sending that misleading notification(it also removes the accidental email channel that this issue reports being
lost on the failure path).
Note: this PR addresses the notification-inconsistency part of #30044 (the
reporter's option 3). The broader question of sending Cal.diy's confirmation
emails when a calendar integration fails (options 1 and 2) is a larger
behavior change and is left to a follow-up.
Visual Demo (For contributors especially)
N/A - this is a one-line API parameter change; behavior is covered by the unit
test assertion added in this PR.
Video Demo (if applicable):
N/A
Image Demo (if applicable):
N/A
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.ts- thecreateEvent > should patch event location with hangoutLink when event is created with hangoutLinktest now asserts that the follow-upevents.patchcall includessendUpdates: "none".yarn vitest run packages/app-store/googlecalendar/lib/__tests__/CalendarService.test.tssendUpdates) before the fix and passes after it.Checklist
Automated by pr-pipeline (com.ashutosh.prpipeline).