feat(console): allow Google sign-in to the console project - #13385
Open
HarshMN2345 wants to merge 1 commit into
Open
feat(console): allow Google sign-in to the console project#13385HarshMN2345 wants to merge 1 commit into
HarshMN2345 wants to merge 1 commit into
Conversation
Adds a Google slot to the console project's oAuthProviders, following the
same {provider}Enabled / {provider}Appid / {provider}Secret contract that
app/controllers/api/account.php reads at sign-in.
Without it createOAuth2Session('google') fails the Enabled check with
project_provider_disabled, which is what the console currently returns
even though the UI ships a Google button.
Contributor
Greptile SummaryAdds environment-backed Google OAuth credentials to the built-in console project, enabling console Google sign-in when both credentials are configured.
Confidence Score: 5/5The PR appears safe to merge, with Google following the existing console OAuth configuration and credential-validation behavior. The account OAuth flow consumes the added console-project fields and rejects missing client IDs or secrets before redirecting, while configured credentials enable the intended Google sign-in path. Important Files Changed
Reviews (1): Last reviewed commit: "feat(console): allow Google sign-in to t..." | Re-trigger Greptile |
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Google slot to the console project's
oAuthProviders, matching the GitHub/GitLab/Bitbucket entries added previously.Why
The console UI already ships a Sign in with Google button, but the API returns:
because the console project has no
googleEnabled/googleAppid/googleSecretkeys — there's nowhere to put credentials. Same gap GitLab and Bitbucket had before #13337.googleis already a supported provider inapp/config/oAuthProviders.php, so no adapter work is needed.Deploying
Set on the console environment, with the OAuth client's redirect URI as
/v1/account/sessions/oauth2/callback/google/console:Unlike GitLab, Google's secret is a plain string — no JSON wrapping.
Matching cloud-side change: appwrite-labs/cloud (same branch name).
Test plan
php -lclean/v1/account/sessions/oauth2/google301s toaccounts.google.com