fix(core): allow style attributes in DomSanitizer - #70425
Open
JeanMeche wants to merge 1 commit into
Open
Conversation
Modern browsers no longer execute JavaScript from within CSS (e.g., via `expression(...)` or `-moz-binding`), eliminating the primary XSS vector associated with inline styles. Because of this, Angular previously removed its internal `StyleSanitizer` in v14 (PR angular#43339). This commit aligns `DomSanitizer.sanitize(SecurityContext.HTML, ...)` with the current security model by adding `style` to the list of allowed HTML attributes. Safe `style` attributes will no longer be stripped from HTML output, while still being properly entity-encoded to prevent attribute breakout. Closes angular#45270
alan-agius4
approved these changes
Aug 27, 2026
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: fw-security
Member
Author
|
Presubmit failure is legit. A dialog with some custom HTML (with a style attribute) now gets styled. Marking this as a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern browsers no longer execute JavaScript from within CSS (e.g., via
expression(...)or-moz-binding), eliminating the primary XSS vector associated with inline styles. Because of this, Angular previously removed its internalStyleSanitizerin v14 (PR #43339). This commit alignsDomSanitizer.sanitize(SecurityContext.HTML, ...)with the current security model by addingstyleto the list of allowed HTML attributes. Safestyleattributes will no longer be stripped from HTML output, while still being properly entity-encoded to prevent attribute breakout.Closes #45270