fix(core): experimental rebuild of corrupted embedded-view TView (WIP, not ready to ship) - #70406
Draft
arturovt wants to merge 1 commit into
Draft
Conversation
…, not ready to ship) Explores a root-cause fix for the NG0510 getParentRElement crash fixed on fix/core-hydration-sibling-skip-crash: rebuild an embedded view's TView when incompleteFirstPass is set, mirroring what getOrCreateComponentTView() already does for component TViews. Confirmed manually this makes the crash disappear entirely, but it uncovers a second, separate bug: the aborted first attempt's partially-created LView/DOM is never torn down, so retried content gets appended alongside orphaned leftovers instead of replacing them (silent duplication instead of a loud crash). Not shippable as-is. Full writeup, root-cause trace decode, and next steps in NOTES-incomplete-first-pass-tview-rebuild.md.
arturovt
force-pushed
the
experimental/embedded-tview-incomplete-pass-rebuild
branch
from
August 26, 2026 20:09
a651cf1 to
246618c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explores a root-cause fix for the NG0510 getParentRElement crash fixed on fix/core-hydration-sibling-skip-crash: rebuild an embedded view's TView when incompleteFirstPass is set, mirroring what getOrCreateComponentTView() already does for component TViews.
Confirmed manually this makes the crash disappear entirely, but it uncovers a second, separate bug: the aborted first attempt's partially-created LView/DOM is never torn down, so retried content gets appended alongside orphaned leftovers instead of replacing them (silent duplication instead of a loud crash). Not shippable as-is.
Full writeup, root-cause trace decode, and next steps in NOTES-incomplete-first-pass-tview-rebuild.md.