Fix IPv6 support and support listening to a specific IP - #2226
Merged
Conversation
Reorder build steps such that intermediate steps can more likely be reused, in particular installed apt, npm and mix packages.
config/runtime.exs: new variable PHX_HTTP_IP for specifying IP address to bind to; Logflare.Repo, :postgres_backend_adapter: set socket-options for IPv6; SharedRepo, ContextCache.Supervisor: hand socket-options on; update docs; update .template.env;
Ziinc
requested changes
Oct 15, 2024
Contributor
|
Thanks for the PR, looks like a good addition for self hosting setup |
runtime.exs: adapt logic from supabase/realtime:Realtime.Database.detect_ip_version/1; use :inet.parse_address/1 instead of IP.from_string!/1; shared_repo.ex: apply code-review suggestion;
Ziinc
requested changes
Nov 4, 2024
Ziinc
left a comment
Contributor
There was a problem hiding this comment.
thanks for the adjustments, was OOO. I can take over the postgres adaptor backend adjustments needed.
| opts ++ fields | ||
| end | ||
|
|
||
| opts = opts ++ [socket_options: config[:socket_options]] |
Contributor
There was a problem hiding this comment.
@tvogel this shouldn't use the global config actually, we can add this in temporarily but it should be part of the backend's config instead. This would require adjusting the self-hosted backend config building.
Contributor
Author
There was a problem hiding this comment.
Why shouldn't it use the socket_options determined for the respective DB_HOSTNAME which it determines in
Map.take(config, [:username, :password, :hostname, :database, :port, :ssl])
? In which cases would you use different options?
Contributor
There was a problem hiding this comment.
In this case, with inserts into one postgres instance it is ok. However, it will not apply in the situation where there is 2 postgres instances in a multi-backend setup, 1 on ipv6 and the other on ipv4. The same socket options would not apply
Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Contributor
Author
|
(Sorry for the late replies - I was traveling.) |
|
@Ziinc, any update on this pull request? Hitting this issue currently as well and would love for this to be merged. |
Contributor
|
@tvogel could you adjust the two remaining issues for the merge?
|
Ziinc
added a commit
that referenced
this pull request
Jul 30, 2025
* perf: reduce docker rebuild overhead Reorder build steps such that intermediate steps can more likely be reused, in particular installed apt, npm and mix packages. * fix: support IPv6, allow specific binding to IPs config/runtime.exs: new variable PHX_HTTP_IP for specifying IP address to bind to; Logflare.Repo, :postgres_backend_adapter: set socket-options for IPv6; SharedRepo, ContextCache.Supervisor: hand socket-options on; update docs; update .template.env; * fix: address code-review runtime.exs: adapt logic from supabase/realtime:Realtime.Database.detect_ip_version/1; use :inet.parse_address/1 instead of IP.from_string!/1; shared_repo.ex: apply code-review suggestion; * address formatting linter * Update mix.exs: remove dependency not longer required Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * fix: only forward socket opts for single tenant PG * fix: fallback for host * fix: fallback for socket options --------- Co-authored-by: Chase Granberry <chase@logflare.app> Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Ziinc
added a commit
that referenced
this pull request
Aug 21, 2025
* perf: reduce docker rebuild overhead Reorder build steps such that intermediate steps can more likely be reused, in particular installed apt, npm and mix packages. * fix: support IPv6, allow specific binding to IPs config/runtime.exs: new variable PHX_HTTP_IP for specifying IP address to bind to; Logflare.Repo, :postgres_backend_adapter: set socket-options for IPv6; SharedRepo, ContextCache.Supervisor: hand socket-options on; update docs; update .template.env; * fix: address code-review runtime.exs: adapt logic from supabase/realtime:Realtime.Database.detect_ip_version/1; use :inet.parse_address/1 instead of IP.from_string!/1; shared_repo.ex: apply code-review suggestion; * address formatting linter * Update mix.exs: remove dependency not longer required Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * fix: only forward socket opts for single tenant PG * fix: fallback for host * fix: fallback for socket options --------- Co-authored-by: Chase Granberry <chase@logflare.app> Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Ziinc
added a commit
that referenced
this pull request
Aug 21, 2025
* Fix IPv6 support and support listening to a specific IP (#2226) * perf: reduce docker rebuild overhead Reorder build steps such that intermediate steps can more likely be reused, in particular installed apt, npm and mix packages. * fix: support IPv6, allow specific binding to IPs config/runtime.exs: new variable PHX_HTTP_IP for specifying IP address to bind to; Logflare.Repo, :postgres_backend_adapter: set socket-options for IPv6; SharedRepo, ContextCache.Supervisor: hand socket-options on; update docs; update .template.env; * fix: address code-review runtime.exs: adapt logic from supabase/realtime:Realtime.Database.detect_ip_version/1; use :inet.parse_address/1 instead of IP.from_string!/1; shared_repo.ex: apply code-review suggestion; * address formatting linter * Update mix.exs: remove dependency not longer required Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * fix: only forward socket opts for single tenant PG * fix: fallback for host * fix: fallback for socket options --------- Co-authored-by: Chase Granberry <chase@logflare.app> Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * chore: fix compilation errors * chore: remove net_address from lockfile * chore: PR comments --------- Co-authored-by: Tilman Vogel <tilman.vogel@web.de> Co-authored-by: Chase Granberry <chase@logflare.app>
djwhitt
pushed a commit
that referenced
this pull request
May 18, 2026
* Fix IPv6 support and support listening to a specific IP (#2226) * perf: reduce docker rebuild overhead Reorder build steps such that intermediate steps can more likely be reused, in particular installed apt, npm and mix packages. * fix: support IPv6, allow specific binding to IPs config/runtime.exs: new variable PHX_HTTP_IP for specifying IP address to bind to; Logflare.Repo, :postgres_backend_adapter: set socket-options for IPv6; SharedRepo, ContextCache.Supervisor: hand socket-options on; update docs; update .template.env; * fix: address code-review runtime.exs: adapt logic from supabase/realtime:Realtime.Database.detect_ip_version/1; use :inet.parse_address/1 instead of IP.from_string!/1; shared_repo.ex: apply code-review suggestion; * address formatting linter * Update mix.exs: remove dependency not longer required Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * fix: only forward socket opts for single tenant PG * fix: fallback for host * fix: fallback for socket options --------- Co-authored-by: Chase Granberry <chase@logflare.app> Co-authored-by: Ziinc <Ziinc@users.noreply.github.com> * chore: fix compilation errors * chore: remove net_address from lockfile * chore: PR comments --------- Co-authored-by: Tilman Vogel <tilman.vogel@web.de> Co-authored-by: Chase Granberry <chase@logflare.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For running logflare on fly.io with their IPv6 based private networking, I had to fix/improve a few things. Please take a look and pick what you like!
(My first exposure to Elixir/Erlang, so thanks for that!)