Honor MetricReader temporality preference in OtelMetrics - #7500
Open
Sanjay-doppalapudi wants to merge 1 commit into
Open
Honor MetricReader temporality preference in OtelMetrics#7500Sanjay-doppalapudi wants to merge 1 commit into
Sanjay-doppalapudi wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 192e99e The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sanjay-doppalapudi
requested a deployment
to
fork
August 27, 2026 22:53 — with 
GitHub Actions
Waiting
Sanjay-doppalapudi
requested a deployment
to
fork
August 27, 2026 22:53 — with
GitHub Actions
Waiting
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OtelMetrics'MetricProducerstamped every data point with the producer-leveltemporalityoption, which defaults to cumulative, and never consulted theMetricReaderit was registered with — so an exporter'stemporalityPreference(e.g.OTLPMetricExporter({ temporalityPreference: AggregationTemporality.DELTA })) was silently ignored unless the same preference was repeated onOtelMetrics.layer.The producer now resolves temporality per instrument type: an explicit
temporalityoption wins, otherwise the registered reader'sselectAggregationTemporality(instrumentType)decides, falling back to cumulative — matching the OTel spec and the SDK's own delta selector (counters/histograms delta, up-down counters cumulative). Each reader's forked producer carries its own reader reference, so multiple readers with different preferences each receive correctly shaped data.Tests: reader DELTA preference honored (temporality stamp and delta values across two collects), per-instrument-type selection (COUNTER delta while UP_DOWN_COUNTER stays cumulative), and explicit-option-over-reader precedence. Two of the three fail against the unfixed source.
Closes #6253 (for v4; the linked PR #6263 covers the frozen v3 branch).